search

VirtCode / SmartMouse

use your smartphone as a normal computer mouse
GNU General Public License v3.0
97 stars 6 forks source link

Breaks homescreen default #15

Closed StickyDigit closed 5 months ago

StickyDigit commented 6 months ago

When this app is installed, my home-screen selection will not 'stick' any more.

To clarify: My home-screen on two devices is Trebuchet, and that is set as default, but I have a couple of other options installed. Normally, I hit home and trebuchet is where I end up. With SmartMouse installed, every time I hit 'home' I get asked which home-screen to use, regardless whether I click 'every time'. Uninstalling the app resolves the issue.

LineageOS 18.1 on two different devices, one with Gapps, one without.

VirtCode commented 6 months ago

hmm that's very odd

My first guess would be that it is in some way related to this app trying to suppress the home, back, etc. buttons when in mouse view to prevent accidental touches. But that doesn't explain at all why it is also happening when leaving other apps... I'll remove that some time soon anyways, as it does not really work / is practically impossible to do on most modern android versions. So we'll see whether that fixes it.

I'll keep this open until then as this is far from intended behavior and seems really annoying. Also, if anyone else has a hunch on what else could cause this behavior, let me know!

nate-moo commented 5 months ago

Can confirm this is an issue, and Nova launcher is actually what alerted me to the bug in this app.

I can test things if needed and/or provide specific logs if desired.

VirtCode commented 5 months ago

Thanks for the hint, I can also reproduce the issue with the nova launcher! I think I have also found the issue, which was an unneeded intent category which was left over from some time ago. I've removed that in the latest commit (https://github.com/VirtCode/SmartMouse/commit/897628c0df4d50abfe2c9140676e71153cbaf26e) and that fixes it for me.

I'd be glad if you could test this on your end, and also if someone could test this on LineageOS. I'll upload a build here tomorrow (when I have access to my signature keys), so you don't have to try build it yourself.

VirtCode commented 5 months ago

Here's a build of that commit. I'd be glad if someone could test this especially on LineageOS. The build is in a zip because GitHub won't let me upload an apk: SmartMouse-897628c-launcher-fix.zip

StickyDigit commented 5 months ago

That's working for e on the LineageOS device I raised the issue for.

VirtCode commented 5 months ago

That's great, thanks for testing! I'll close this then.