search

VirtoCommerce / vc-module-marketing

Marketing module: promotions and dynamic content
Other
9 stars 11 forks source link

VirtoCommerce.Orders Module Dependency #235

Open wsimon opened 1 month ago

wsimon commented 1 month ago

Does this module really require the Orders Module? What about Customers Module? These dependencies here: https://github.com/VirtoCommerce/vc-module-marketing/blob/dev/src/VirtoCommerce.MarketingModule.Web/module.manifest#L12-L15

We don't have any need for the Orders module, for example, and the Orders modules depends on other modules that we do not need. So was just curious if it would be possible to make some of those optional dependencies so that we could remove some of these extra unneeded modules.

mvktsk commented 1 month ago

Task https://virtocommerce.atlassian.net/browse/VP-8641 has been created

OlegoO commented 1 month ago

@wsimon Thank you for the feedback. It's a good question and a point for improvement. I created a story to eliminate/change to optional dependency on Order and Customer Modules and put it into the next sprint. I will ping you when we have PR and Alfa for testing.

At the same time, could you describe your solution and scenarious. Are you planning to use Virto Commerce Frontend?

Reference: At this moment both Order and Customer modules are being used in the Marketing module here: https://github.com/VirtoCommerce/vc-module-marketing/blob/7e3f8ac0901fc330637a40190ca5c2c29875a9e1/src/VirtoCommerce.MarketingModule.Data/Handlers/CouponUsageRecordHandler.cs#L105 https://github.com/VirtoCommerce/vc-module-marketing/blob/7e3f8ac0901fc330637a40190ca5c2c29875a9e1/src/VirtoCommerce.MarketingModule.Web/Scripts/promotion/blades/coupon-detail.js#L80

wsimon commented 1 month ago

Sounds good. No we don't use the frontend. We use the catalog, pricing and other configuration from platform in our own store frontend.