search

VirtoCommerce / vc-platform-core

Project moved to https://github.com/VirtoCommerce/vc-platform/tree/release/3.0.0
Other
38 stars 32 forks source link

Proposed additional fixes to external authentication. #558

Open keberle opened 5 years ago

keberle commented 5 years ago

The pull request I submitted 12 days ago to eliminate the AzureAD config from throwing an exception at startup addressed our need to be able to login to the admin UI with AzureAD (or other OpenID Connect option) but to get that working in a kubernetes container I need forwarded header support. Otherwise, the protocol on the callback url is wrong behind a proxy.

I have that working and it doesn't break anything but it doesn't do me any good to submit that in a pull request is the AzureAD fix is going to be rejected. Can someone weigh in on whether that fix to the startup issue is acceptable before I submit the forwarded headers support pull request?

Thanks.

tatarincev commented 5 years ago

@keberle We take a look at this today

tatarincev commented 5 years ago

I've applied your PR by this commit https://github.com/VirtoCommerce/vc-platform-core/commit/465683ca69ea007dd021f22910c0195979b2f18b

keberle commented 5 years ago

@tatarincev Great. Thank you. I'll submit the PR for the forwarded protocol header soon. That should help anyone running this behind a proxy.