search

VirtoCommerce / vc-storefront-deprecated

VirtoCommerce Storefront for ASP.NET (.NET Framework) repository (DEPRECATED)
http://virtocommerce.com
Other
26 stars 113 forks source link

3 test fails on storefront #58

Closed asvishnyakov closed 6 years ago

asvishnyakov commented 6 years ago

SerializationTests and ShoppingCartTests fails, but because they don't have Trait attribute, storefront successfully builded on CI

Andrew-Orlov commented 6 years ago

These tests are currently not passing. Should they be included in the CI?

Andrew-Orlov commented 6 years ago

Fixed shopping cart and serialization tests. Shopping cart test was added to Integration category, serialization tests was added to Unit category.

asvishnyakov commented 6 years ago

@Andrew-Orlov Formally you fixed problem described in this issue. So thank you for your work. But I think the problem is little more complex: I think we must find (in storefront) and analyze all tests not marked with Trait attribute and then do one of the following: remove test as invalid or fix it (if it's outdated or has wrong implementation) and then mark it as unit or integration test.

asvishnyakov commented 6 years ago

@Andrew-Orlov Look at all tests, verify what they valid (i.e. for example ProductAvailabilityTest tests all cases when product may be valid and not) and mark this tests with Trait attribute if they valid or create issue to fix test if it is not valid. @tatarincev Aprroved this

OlegoO commented 6 years ago

Will create a new ticket for all tests and verify what they valid