VirtoCommerce / vc-theme-default

Default theme for VirtoCommerce Storefront
http://demo.virtocommerce.com/Electronics
Other
3 stars 41 forks source link

Added packJavaScript task to default gulp task #181

Open loktar00 opened 3 years ago

loktar00 commented 3 years ago

When running the default gulp task the scripts_dependencies.js file is never created, this is required to run the templates otherwise you receive an error. The default task also cleans the directory removing the file if it was there and doesn't regenerate it.

This PR just adds the packJavaScript task which generates the above file so a user can run the default task in order to test their template changes.

CLAassistant commented 3 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Jason Brown seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

mvktsk commented 3 years ago

Review task https://virtocommerce.atlassian.net/browse/VP-7709 has been created

loktar00 commented 3 years ago

Sorry for the weird commit there.. new machine git creds weren't setup.