search

VirtoCommerce / vc-theme-default

Default theme for VirtoCommerce Storefront
http://demo.virtocommerce.com/Electronics
Other
3 stars 41 forks source link

possible exception with minification #76

Closed kamilgarey closed 4 years ago

kamilgarey commented 5 years ago

js minification now take scripts in alphabetical order. Usually files need only reference to angular module storefrontApp (over dependencies comes thru angular DI) . As it is declared in app.js which usually comes first in minification order we have no problems. But if we create a file who comes first in order and reference to module (which we usually do) we'll got angular error in storefront after minification .

Steps to reproduce

  1. add "answer.js" to assets/js which contains " angular.module('storefrontApp'); "
  2. minify 3.Update browser cache.
yecli commented 5 years ago

Moved to "On hold" as theme bundling is going to be reworked.

eMazeika commented 5 years ago

that's a "well known old issue". Hopefully, we can get new recommendations / solution on this after "reworked".

tatarincev commented 4 years ago

This issue has been closed because it has no longer relevant to the current operation nature of issues. You may reopen this issue if it has been closed in error.