search

VirtoCommerce / vc-theme-default

Default theme for VirtoCommerce Storefront
http://demo.virtocommerce.com/Electronics
Other
3 stars 41 forks source link

Minificaton issues were added to description #78

Closed kamilgarey closed 5 years ago

kamilgarey commented 5 years ago

These are the problems I came across and I mentioned it earlier. Now it looks

CLAassistant commented 5 years ago

CLA assistant check
All committers have signed the CLA.

eMazeika commented 5 years ago

@kamilgarey was there a ticket, can you connect this PR to it?

kamilgarey commented 5 years ago

@kamilgarey was there a ticket, can you connect this PR to it?

For first two issues there are no tickets. I don't think we should fix it at all. For the third ticket there is an issue it's linked in description. Should I connect this issue to PR?

eMazeika commented 5 years ago

@kamilgarey was there a ticket, can you connect this PR to it?

For first two issues there are no tickets. I don't think we should fix it at all. For the third ticket there is an issue it's linked in description. Should I connect this issue to PR?

not sure what is 1 and what's 2. Yes, connect ticket to PR

kamilgarey commented 5 years ago

I'm not sure should I connect while the commit not fix the issue but just mention it. Should I?