Nginx 1.25.3 won't compile due to Brotli

VirtuBox / nginx-ee

Automated Nginx compilation with HTTP/3 and additional modules support. Compatible with WordOps, EasyEngine & Plesk

https://virtubox.github.io/nginx-ee/

MIT License

203 stars 58 forks source link

Nginx 1.25.3 won't compile due to Brotli #151

Closed janiosarmento closed 10 months ago

janiosarmento commented 11 months ago

When trying to compile Nginx 1.25.3 the script will fail on "Configuring Nginx build". The log will show:

adding module in ../ngx_brotli

./configure: error: Brotli library is missing from the ../ngx_brotli/deps/brotli/c directory.

Please make sure that the git submodule has been checked out:

    cd ../ngx_brotli && git submodule update --init && cd /usr/local/src/nginx

In order to solve this bug, the git clone command for brotli must include --recursive.

janiosarmento commented 11 months ago

No need to say, but...

I sent the PR after testing and making sure --recursive would solve the issue (my Nginx is already on 1.25.3 after that).

VirtuBox commented 10 months ago

Thanks for your pull request and your contribution @janiosarmento