search

Virtual-Coffee / podcast-transcripts

SRT files for podcast episodes
0 stars 3 forks source link

Cljarvis 4 7 transcript #111

Open ClJarvis opened 12 months ago

ClJarvis commented 12 months ago

Improve transcription Season 4 Episode 7

Description

This PR improves transcript Season 4 Episode 7 with Jessica Wilkins. Growing your tech career through writing.

Related Issue

Closes #52

adiati98 commented 12 months ago

Hey @ClJarvis, Does with this PR mean that you want to close #110?

Also, when I run yarn check-srt, I can see many lines have incorrect timestamps.

incorrect timestamps

As I mentioned I haven't checked the whole thing. Can you please check and fix everything's needed before I or @danieltott can review your PR? Thank you 🙂

ClJarvis commented 12 months ago

Yes close the other one. I'll work on this one.

ClJarvis commented 12 months ago

Still working on it. Not sure why it dislike the first time speakers are mentioned. Or which 00 it is referring to.

checking 4_7.srt possible bad names / colon error:

adiati98 commented 12 months ago

Still working on it. Not sure why it dislike the first time speakers are mentioned. Or which 00 it is referring to.

checking 4_7.srt possible bad names / colon error:

  • Bekah Hawrot Weigel
  • Dan Ott
  • Jessica Wilkins
  • 00

We are now working with new guidelines. So, use only the first name of each speaker: Bekah, Dan, and Jessica.

As for the 00, there's no other way than to search it manually 😅.

ClJarvis commented 12 months ago

There was a double timestamp. it has been removed. srt-check run without errors.

adiati98 commented 12 months ago

@ClJarvis let me know when it's ready for review :) It may take a while, so I'll make sure to add hacktoberfest-accepted label if I'm not done reviewing in 3 days.

adiati98 commented 11 months ago

@danieltott this PR is ready for final review. Thank you! :)

ClJarvis commented 11 months ago

Thanks, I will be off line most of the weekend. So If there's changes need I won't be able to get to them till Monday.

ClJarvis commented 10 months ago

Is this ready to be merged? Any changes needed?

adiati98 commented 10 months ago

@ClJarvis, there are no changes needed. @danieltott will merge this when he uploads it to Buzzsprout 🙂