Virtual-Coffee / virtualcoffee.io

Public site for Virtual Coffee
https://virtualcoffee.io
Other
232 stars 247 forks source link

Peekaboo with the navigation bar #823

Closed bogdaaamn closed 1 month ago

bogdaaamn commented 1 year ago

Is there an existing issue for this?

What happened?

Not sure if this is a bug or a feature, but the nav bar is visible but not interactive on scroll up all the way up on the landing page. Also it stay visible if there is focus within.

https://user-images.githubusercontent.com/22895284/222702927-615485f3-7192-467b-9b68-7b0fecd9dee2.mov

I think the idea is to hide the bar when scrolled all the way up and reveal it later, right? But I scrolled too much and revealed the bar by mistake, I can't unsee it and I wanna press it 😭

Steps To Reproduce

  1. Go to https://virtualcoffee.io/
  2. Scroll up for no reason

What browsers are you seeing the problem on?

Chrome

Environment

- OS: MacOS Ventura 13.0

Anything else?

I love issues forms, I didn't know we have them omg

Code of Conduct

redapy commented 1 year ago

@BogDAAAMN @BekahHW what is the expected behavior?

danieltott commented 1 year ago

This is the expected behavior 👍🏼

danieltott commented 1 year ago

OH - nm, i watched the video. this isn't scroll all the way up, it's scroll past the top. That's interesting. Can we disable it? or cover it somehow.

danieltott commented 1 year ago

Looks like overscroll-behavior-y:none might do it

bogdaaamn commented 1 year ago

it's me

danieltott commented 1 year ago

@redapy you interested?

dreymoreau commented 1 year ago

hi! i would like to fix this bug :)

danieltott commented 1 year ago

@dreymoreau it's all you!

dreymoreau commented 1 year ago

readme png error png

@danieltott hi! followed the readme instructions but got this error when trying to build, wondering about further clarification on how to get it working when building locally?

redapy commented 1 year ago

@danieltott sorry for the late response, I was a bit busy. However, I can't reproduce the behavior on my MacOS Monterey 12.6. Please let me know if there is anything I can help with!

danieltott commented 1 year ago

@dreymoreau just to cover our bases, I assume you tried to stop the server and re-start it?

Also, can you paste in the following versions:

dreymoreau commented 1 year ago

hi! @danieltott sorry for getting back to you late node version : 19.8.1 yarn version: 1.22.19 for netlify-cli, it prompts this even though i have it installed and have used the command for the latest version

Preview README md - virtual-coffee - Visual Studio Code 2023-04-07 5_11_03 PM

sameer-soni commented 1 year ago

Hi there! I've created a pull request (#959 ) to address this issue. Please take a look when you have a moment. Thanks!

danieltott commented 1 year ago

@dreymoreau I'm sorry about the delay helping you out here. Do you still want to take a crack at this? I believe @adiati98 has gotten the site running on windows so she may be able to help...

adiati98 commented 1 year ago

@danieltott as this is on the homepage where we need to fetch (fake?) data, it always crash on Windows. I mostly work on newsletter and monthly challenge pages where we don't need to fetch data from 3rd party. I have no solution yet on this for Windows users.

One way is to work on this blindly, and create a draft PR. We can always see the result through Netlify. This is what I normally do when necessary 😁.

dominicduffin1 commented 1 year ago

If @dreymoreau still wants to work on this I might be able to help figure out how to get it running on Windows (I believe I did get it running in the past but I can't remember how🙂). Another option if your system supports it is to try Windows Subsystem for Linux (which I can also help with).

adiati98 commented 1 year ago

@dominicduffin1 I will be interested to know how to get the homepage running on Windows (not WSL... yet 😁).

danieltott commented 1 month ago

closed via 74a0c079fb1d2a1b77acf8963af701706cfe6b50