VirtualEngine / Lability

Virtual Engine test lab deployment and configuration module
MIT License
283 stars 50 forks source link

Errors with slashes in GitHub repo names #361

Closed codykonior closed 5 years ago

codykonior commented 5 years ago

I added a DSCResource entry like so:

    NonNodeData = @{
        Lability = @{
            # These resources are copied to the VM. If any are missing (except PSDesiredStateConfiguration) the first boot
            # will hang because DSC doesn't complete. Stopping and starting the VM will allow you to login to see the logs.
            DSCResource = @(
                @{ Name = 'ComputerManagementDsc'; RequiredVersion = '6.4.0.0'; }
                @{ Name = 'NetworkingDsc'; RequiredVersion = '7.2.0.0'; }
                @{ Name = 'xActiveDirectory'; RequiredVersion = '2.26.0.0'; }
                @{ Name = 'xDnsServer'; RequiredVersion = '1.12.0.0'; }
                @{ Name = 'xRemoteDesktopAdmin'; RequiredVersion = '1.1.0.0'; }
                @{ Name = 'xSmbShare'; RequiredVersion = '2.2.0.0'; }
                @{ Name = 'xSystemSecurity'; RequiredVersion = '1.4.0.0'; }
                @{ Name = 'xWindowsUpdate'; RequiredVersion = '2.8.0.0'; }
                @{ Name = 'xFailOverCluster'; RequiredVersion = '1.12.0.0'; }
                @{ Name = 'xPSDesiredStateConfiguration'; RequiredVersion = '8.7.0.0'; }
                # @{ Name = 'SqlServerDsc'; RequiredVersion = '12.5.0.0'; }

                @{ Name = 'SqlServerDsc'; RequiredVersion = '12.5.0.0'; Provider = 'GitHub'; Owner = "codykonior"; Branch = "codykonior/upgrade"; }
            )

It did not like the codykonior/upgrade as a branch name. It results in an error like this:

Get-LabModuleCacheManifest C:\ProgramData\Lability\Modules\SqlServerDsc_codykonior_codykonior\upgrade.zip GitHub
Remove-Item : Cannot find path 'C:\Users\Cody.Konior\AppData\Local\Temp\upgrade.zip.psd1' because it does not exist.
At line:72 char:13
+             Remove-Item -Path $temporaryArchivePath -Force;
+             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (C:\Users\Cody.K...pgrade.zip.psd1:String) [Remove-Item], ItemNotFoundEx
   ception
    + FullyQualifiedErrorId : PathNotFound,Microsoft.PowerShell.Commands.RemoveItemCommand

Some projects ask for branches in this format to make identifying who owns the branch easier.