VirtualFlyBrain / VFB

Virtual Fly Brain
www.virtualflybrain.org
GNU General Public License v2.0
16 stars 5 forks source link

Not possible to use alternative id #582

Open mmc46 opened 9 years ago

mmc46 commented 9 years ago

Using the alternative id directly on the url does't resolve to any page. When terms are merged, one id is kept as main, the other as alternative (in obo file 'id' and 'alt_id' respectively). Using the alternative id should resolve to the same page as the main id.

Example:
alpha'/beta' anterior Kenyon cell ; FBbt:00100250 has changed name to alpha'/beta' anterior-posterior Kenyon cell (the two terms, anterior FBbt:00100250, and posterior FBbt:00100254 were merged, with one id being the main and the other the alternative one, respectively).

Using the alternative id FBbt:00100254 directly on the url does't resolve. It should bring up same page as with the main id.

http://www.virtualflybrain.org/site/tools/anatomy_finder/index.htm?id=FBbt:00100250

http://www.virtualflybrain.org/site/tools/anatomy_finder/index.htm?id=FBbt:00100254

This issue seems to affect all merged terms (267 merged terms in whole ontology, not just neuro).

Robbie1977 commented 9 years ago

A search with obo format id works in new solr however would be better to include owl style id in alternative. "has_alternative_id_annotation":["FBbt:00100254"],

{
        "id":"fbbt:http://purl.obolibrary.org/obo/FBbt_00100250",
        "uri":"http://purl.obolibrary.org/obo/FBbt_00100250",
        "short_form":["FBbt_00100250",
          "FBbt:00100250"],
        "label":"alpha'/beta' anterior-posterior Kenyon cell",
        "label_suggest":["alpha'/beta' anterior-posterior Kenyon cell",
          "mushroom body alpha'/beta' anterior neuron",
          "alpha'/beta'p",
          "alpha'p",
          "beta'a",
          "alpha'/beta'a neuron",
          "alpha'/beta'a",
          "mushroom body alpha'/beta' posterior neuron",
          "alpha'/beta'p neuron",
          "alpha'/beta' anterior neuron",
          "alpha'/beta' ap Kenyon cell",
          "mushroom body alpha-prime/beta-prime anterior neuron",
          "alpha'/beta' posterior neuron",
          "mushroom body alpha-prime/beta-prime posterior neuron",
          "beta'p",
          "alpha'a",
          "mushroom body alpha'/beta' anterior Kenyon cell"],
        "synonym":["mushroom body alpha'/beta' anterior neuron",
          "alpha'/beta'p",
          "alpha'p",
          "beta'a",
          "alpha'/beta'a neuron",
          "alpha'/beta'a",
          "mushroom body alpha'/beta' posterior neuron",
          "alpha'/beta'p neuron",
          "alpha'/beta' anterior neuron",
          "alpha'/beta' ap Kenyon cell",
          "mushroom body alpha-prime/beta-prime anterior neuron",
          "alpha'/beta' posterior neuron",
          "mushroom body alpha-prime/beta-prime posterior neuron",
          "beta'p",
          "alpha'a",
          "mushroom body alpha'/beta' anterior Kenyon cell"],
        "description":["A subgroup of the mushroom body alpha'/beta' neurons that has dendrites in the main calyx and project axons to the anterior and posterior layers of the alpha'/beta' lobes. There are around 210 neurons in each hemisphere."],
        "ontology_name":"fbbt",
        "ontology_uri":"http://purl.obolibrary.org/obo/fbbt/vfb/2015-03-26/fbbt_vfb_ind_pr_nr.owl ",
        "type":"class",
        "is_defining_ontology":false,
        "has_children":false,
        "is_root":false,
        "logical_description":["has_presynaptic_terminal_in some mushroom body alpha'-lobe",
          "has_presynaptic_terminal_in some mushroom body beta'-lobe"],
        "creation_date_annotation":["2010-09-09T04:26:05Z"],
        "id_annotation":["FBbt:00100250"],
        "database_cross_reference_annotation":["VFB:FBbt_00100250"],
        "has_obo_namespace_annotation":["fly_anatomy.ontology"],
        "comment_annotation":["Comparison of the expression patterns of the enhancer traps NP65, NP1131, NP6522 and NP7427 prompted the classification of three subpopulations (anterior, middle and posterior) of alpha'/beta' neurons by Tanaka et al., (2008), according to their terminal positions. Aso et al. (2014) showed that there are only two subtypes, anterior-posterior and middle. Comparisons using these enhancer trap lines suggests that the neurons terminating in the anterior of the alpha' lobe are the same subclass as those terminating in the anterior of the beta' lobe (Tanaka et al., 2008)."],
        "created_by_annotation":["sr544"],
        "has_alternative_id_annotation":["FBbt:00100254"],
        "bbop_sibling_graph_json":"",
        "_version_":1505930807317889024,
        "score":0.23806034},
      {
        "id":"fbbt:http://purl.obolibrary.org/obo/FBbt_00050225",
        "uri":"http://purl.obolibrary.org/obo/FBbt_00050225",
        "short_form":["FBbt:00050225",
          "FBbt_00050225"],
        "label":"neuroblast VLPl2",
        "label_suggest":["neuroblast VLPl2"],
        "description":["."],
        "ontology_name":"fbbt",
        "ontology_uri":"http://purl.obolibrary.org/obo/fbbt/vfb/2015-03-26/fbbt_vfb_ind_pr_nr.owl ",
        "type":"class",
        "is_defining_ontology":false,
        "has_children":false,
        "is_root":false,
        "in_subset_annotation":["TL_lineage_clone"],
        "id_annotation":["FBbt:00050225"],
        "has_obo_namespace_annotation":["fly_anatomy.ontology"],
        "bbop_sibling_graph_json":"",
        "_version_":1505930811971469312,
        "score":0.033547655}]
  }
dosumis commented 8 years ago

Makes sense to add this to SOLR search index.

Planned extension to OBO to OWL conversion will make URIs for alt_ids. This will be marked as obsolete and have a replaced_by axiom indicating redirect to replacement term. Once this is in place, it will be easier to support redirecting URIs for old IDs.

@hdietze (from GO) may be able to comment on possible time frame for this functionality.