VirtualFlyBrain / VFB2

Virtual Fly Brain Documentation Site
https://virtualflybrain.org
MIT License
5 stars 6 forks source link

Term info - example images only showing direct instance #62

Open Robbie1977 opened 6 years ago

Robbie1977 commented 6 years ago

From @dosumis on June 27, 2017 12:23

Unlike VFB 1.5, only direct instances are shown in example images for TermInfo

e.g. see 'uniglomerular antennal lobe projection neuron'

Cypher:

MATCH (c:Class)<-[:SUBCLASSOF|INSTANCEOF*]-(i:Individual) where c.short_form  = '' RETURN i

Basically this query: https://github.com/VirtualFlyBrain/VFB2/blob/alpha/html/conf/vfb.xmi#L194

Whereas, from the results, it looks like you're using this:

MATCH (c:Class)<-[:INSTANCEOF]-(i:Individual)

(This is broken in VFB 1.5 for painted domains, but all terms should behave the same. So, for example, mushroom body (stage neutral) should display images of 'adult mushroom body'.)

Challenge in current struc is how to fit into the monster query currently driving TermInfo https://github.com/VirtualFlyBrain/VFB2/blob/alpha/html/conf/vfb.xmi#L263

Copied from original issue: VirtualFlyBrain/geppetto-vfb#34

Robbie1977 commented 6 years ago

From @dosumis on June 27, 2017 14:20

e.g.

image

vs

image

But

image

Robbie1977 commented 6 years ago

@dosumis How many layers did you want to go down?

Robbie1977 commented 6 years ago

From @dosumis on June 28, 2017 10:46

In VFB 1.5 there is no set limit. This is potentially slow (but could be very if we moved query to OWL). Given that there are no semantics to 'levels' in OWL, increased detail in classifications could lead to loss of useful results as the ontology evolves. Perhaps it would be better to set a limit to the number returned and add a link immediately under the examples allowing users to query for all?

Robbie1977 commented 6 years ago

I've implemented 1 layer immediately and will look at limiting results based on number of results with closest given priority.

Robbie1977 commented 6 years ago

Any Class with examples gives a query to pull all examples and this explores the full tree

Robbie1977 commented 6 years ago

From @dosumis on June 28, 2017 11:0

I've implemented 1 layer immediately and will look at limiting results based on number of results with closest given priority.

I'm not sure proximity matters - it's just a reflection of how much we know about any given neuron/structure, rather than the nature of the neuron/structure itself. I'd just choose an arbitrary return limit number (say 6 as elsewhere?)

Any Class with examples gives a query to pull all examples and this explores the full tree

Excellent

Robbie1977 commented 6 years ago

From @dosumis on July 11, 2017 11:22

This should not be done as a mega query. Needs to be done separately.