VirtualFlyBrain / VFB_owl

A repository for VFB owl files and the code that generates them
2 stars 1 forks source link

LCN12 annotation #35

Closed dosumis closed 6 years ago

dosumis commented 7 years ago

We seem to have a rather huge number of these, with quite diverse morphologies. http://vfbsandbox3.inf.ed.ac.uk/site/stacks/index.htm?id=FBbt_00100484

Is this annotation correct?

mmc46 commented 7 years ago

It seems to be. They'll tile the lobula, but project to a specific region in the AVLP (target optic glomeruli). There seems to be some subregion specificity, looking at all neurons, but AFAIK not yet described.

dosumis commented 7 years ago

Would be good to be able to trace where the assertion comes from.

mmc46 commented 7 years ago

From work in the NBLAST paper and types described in Otsuna and now Panser.

(This is an issue that applies to any annotation of neuron types to images, which would be good to solve - there isn’t a way to add a reference)

On 21 Mar 2017, at 11:58, David Osumi-Sutherland notifications@github.com wrote:

Would be good to be able to trace where the assertion comes from.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/VirtualFlyBrain/VFB_owl/issues/35#issuecomment-288056797, or mute the thread https://github.com/notifications/unsubscribe-auth/AByQ01XodLcC1OokDZlt7r5y51q-G8Icks5rn7tLgaJpZM4MjmCh.

dosumis commented 7 years ago

@Robbie1977 We should think about how to store this in the KB. Could be comments or references on edges. In this cas:

(:Individual { label 'Cha-F-000018' })
-[:SUBCLASSOF { comment: 'This mapping is based on..', PMID:123456 }]->
(:Class { label : 'lobula columnar neuron Lcn12' })
Robbie1977 commented 7 years ago

Should be possible on both nodes and edges (as relevant) but should also be an array or more likely a Json/dict as we need to link attribution, comment and date info (maybe rating). We should also think about a more general attribution on all nodes and edges stating if officially curated (and from whom: VFB/FB) or user submitted (or reasoned?). It would need to be an iri ref to the curator/user data node as needs to fit on edges too. On Wed, 22 Mar 2017 at 08:48, David Osumi-Sutherland < notifications@github.com> wrote:

@Robbie1977 https://github.com/Robbie1977 We should think about how to store this in the KB. Could be comments or references on edges. In this cas:

(:Individual { label 'Cha-F-000018' })-[:SUBCLASSOF { comment: 'This mapping is based on..', PMID:123456 }]-> (:Class { label : 'lobula columnar neuron Lcn12' })

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/VirtualFlyBrain/VFB_owl/issues/35#issuecomment-288334155, or mute the thread https://github.com/notifications/unsubscribe-auth/AEao8IbEOUX9lDkDldXHMwfxj-uMJNStks5roOBIgaJpZM4MjmCh .

dosumis commented 7 years ago
Robbie1977 commented 7 years ago

evidence needs to be on the edge directly or we risk drastically increasing our node count. Sorry I was expanding the spec to future proof

dosumis commented 7 years ago

RE Json object/dict on attribute: OLS stores maps as attribute values, but does so by packing them into strings:

e.g.

MATCH (c:Class { iri: 'http://purl.obolibrary.org/obo/FBbt_00007238' }) return c.obo_xref

=> image

I believe it is possible to unpack these in cypher (although haven't tried). But certainly no good for querying. Also need to be careful about storing unconstrained arbitrary structured documents like this - something Cypher is really designed to avoid.

dosumis commented 7 years ago

This is potentially relevant:

https://github.com/EBISPOT/OBAN

image

... although I wouldn't want to start putting intermediate nodes into assertions as this would screw up the OWL. We could have something equivalent by just storing evidence IDs on edges. Not clear to me that we need to worry about numbers of nodes too much.

dosumis commented 6 years ago

Discussion of provenance models has moved here: https://github.com/VirtualFlyBrain/schema/issues/1