Extend tests to cover new download and uploader components

ddelpiano commented 3 years ago

Downloader:

not controversial, we can add one instance to the scene that has obj and swc, select all instances and check that the archive has the required data.

Uploader:

To follow up, a good strategy it can be to just test the frontend side of things, so open the modal, select a template, upload an swc and check that the component reacts correctly. Generating the nblast results might result in queueing not needed instances for the file server and also it would be difficult to hold the tests for 30+ mins waiting for the results, plus the strategy for opening the query builder from the url is already covered by other tests so no need to extend tests for that.

ddelpiano commented 3 years ago

changed estimate with the required remaining time to implement the new and fix the broken tests.

ddelpiano commented 3 years ago

@jrmartin fyi @Robbie1977 did some improvements to the test pipeline so that we are able to download the diff (snapshots) when the tests fail. Would you sync with him to know when he is done and merge development into your branch? For now ignore the tests the snapshot tests that are failing since @Robbie1977 will fix them, finish with the 2 new tests. If there is anything else broken other than the snapshot tests let us know. Thx

jrmartin commented 3 years ago

The tests for these are now part of this open PR, with the rest of the uploader too.

Unfortunately because of browser restrictions we can't test the case of uploading a file from the local system, so that wasn't added it.

VirtualFlyBrain / geppetto-vfb

Extend tests to cover new download and uploader components #1192