search

VirtualFlyBrain / geppetto-vfb

VFB (v2) application
https://v2.VirtualFlyBrain.org
Other
3 stars 1 forks source link

QueryChecker not consistent #1361

Open Robbie1977 opened 1 year ago

Robbie1977 commented 1 year ago

Stacking query constraints is working fine in the query builder as seen below (both NBLAST and NeuronBridge queries appear) but in the list returned in the term info derived from query checker (https://github.com/VirtualFlyBrain/uk.ac.vfb.geppetto/blob/download/src/main/java/uk/ac/vfb/geppetto/VFBProcessTermInfoJson.java#L1576 -> https://github.com/openworm/org.geppetto.core/blob/VFBv2.1.1/src/main/java/org/geppetto/core/datasources/QueryChecker.java) the second row of constraints doesn't seem to get checked. Need to check what https://github.com/openworm/org.geppetto.model/blob/VFBv2.1.0.1/src/main/java/org/geppetto/model/datasources/QueryMatchingCriteria.java#L27 is returning.

image

I've created a dev-query-issue branch to keep the issue for testing as going to split out the queries into two to hopefully resolve for release but this problem is affecting other queries so a fix is urgent.

jrmartin commented 1 year ago

@Robbie1977 I have been debugging this today. Is the expected behavior that the queries we see in the drop down of the Query component are also shown on the Term Info?

For the example posted on this card, for VFB001013ce. I see these (screenshot below and same ones as in your screenshot), using branch 'dev-query-issue'. Is the only thing missing on the Term Info the query for NBlast? ' Neurons with similar morphology to part of JRC_LH1518_Brain_2019_20150227_41_F120x [NBLAST mean score] Filter Results' image

jrmartin commented 1 year ago

@ddelpiano @Robbie1977 A fix for this was made on org.geppetto.core https://github.com/openworm/org.geppetto.core/pull/187. The branch feature/186 has the fix, tested locally and it works.