VirtualFlyBrain / neo4j2owl

Semantics preserving mapping of OWL 2 EL and Neo4J. Under development, do not use.
Apache License 2.0
6 stars 4 forks source link

Synonyms inconsistently represented as JSON #38

Closed dosumis closed 4 years ago

dosumis commented 4 years ago

For synonyms and definitions, I thought we’d agreed that all values should be JSON, whether or not the axioms are annotated. Looks like, for synonyms at least, only those with annotations are represented as JSON, e.g.: image

MATCH (n:Anatomy:Class) WHERE EXISTS(n.has_exact_synonym) 
RETURN  n.label, n.short_form, n.has_exact_synonym ORDER BY n.label limit 10

image

The current solution is hard to process: have to check wether string is valid JSON before deciding whether to process.

IIRC - the APs for which axion annotations & values should be represented in JSON are specified here:

https://github.com/VirtualFlyBrain/vfb-prod/blob/master/neo4j2owl-config.yaml#L9

It strikes me that we chose a rather obscure name for this config obo_assumption_overwrite_defaults:

I don't think there's anything particularly OBO-ish about this.

How about represent_values_and_annotations_as_json ?

(Fixing is high priority as this is a requirement for producing valid VFB_json for geppetto.)

matentzn commented 4 years ago

The only obo thing about this (you invented that name at some point) was that it looks at synonyms by the default, not at arbitrary annotation properties.. But I will rename it.

matentzn commented 4 years ago

This is fixed in pdbl.

dosumis commented 4 years ago

Center has multiple values (x,y, co-ords). These are correctly represented as a list.

image