search

VirtualPhotonics / VTS

Virtual Tissue Simulator
https://virtualphotonics.org
Other
34 stars 9 forks source link

Fix the SonarCloud issues in IForwardSover #102

Closed lmalenfant closed 1 year ago

lmalenfant commented 1 year ago

The IForwardSolver interface is not correctly organized and as a result, it causes code issues. When this file is inherited these issues are duplicated in the new class.

Fix the organization in the main file and then in the classes that inherit IForwardSolver.

hayakawa16 commented 1 year ago

Thanks for working on this!

dcuccia commented 1 year ago

Can you describe how they are currently organized, what the code issues are, and how you plan to change it?

lmalenfant commented 1 year ago

Can you describe how they are currently organized, what the code issues are, and how you plan to change it?

Overloads of methods are supposed to be organized together in a class, We are updating the XML comments with what previously were comments in the file and putting the methods together.

Once it is complete, I will make sure you are both included in the PR so you can comment on the changes.

lmalenfant commented 1 year ago

@dcuccia I wanted to give you a chance to review this before we merge since you had asked how it would be implemented. Let me know if you have time to review.