Bugfix/115 bug in 2 of the detectors transmittedmtofxandyandsubregionhistdetector and reflectedmtofxandyandsubregionhistdetector

[lmalenfant]

@hayakawa16 the Sonar Cloud analysis failed because the duplication is 52.5% for this code, I have it set to 20% on our rule but I guess it will go over that number even after we merge (20.8%). This duplication number has been creeping up so even setting it at 20% was not high enough, should I increase it more?

[hayakawa16]

Not sure I understand. Did the duplication increase due to my code changes? Or is it the same percentage as it was before my changes?

[hayakawa16]

If I'm reading the analysis correctly, it is due to the renaming of the file ReflectedMTOfRhoAndSubregionHistDetector.cs. Not sure why.

[lmalenfant]

Not sure I understand. Did the duplication increase due to my code changes? Or is it the same percentage as it was before my changes?

No it didn't but I think now that the files changed, it calculates based on "new code" so this is actually both our changes that caused new code to show 52.5%. The previous code coverage percentage was 20.8% so maybe merging this to master will not fail the analysis. I could also raise it to 21% just to pass this build.

[lmalenfant]

I approved this PR so we can merge as soon as you would like, hopefully it will pass the quality gate.

[sonarcloud[bot]]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

95.7% Coverage
52.5% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

[lmalenfant]

Let's merge this one and keep our fingers crossed that it passes code quality :)