search

VirtualPhotonics / VTS

Virtual Tissue Simulator
https://virtualphotonics.org
Other
34 stars 9 forks source link

Added unit tests for BinaryArraySerializerFactory #128

Closed lmalenfant closed 11 months ago

lmalenfant commented 11 months ago

@hayakawa16 these are my additions for the unit tests for the BinaryArraySerializerFactory, if they look good to you, I can merge them into your branch.

I reorganized the BinaryArraySerializerFactory so that the overloads were together and added XML comments to the public method. I usually would add XML comments to the internal methods also but this file will probably replaced by the refactored one.

sonarcloud[bot] commented 11 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
2.3% 2.3% Duplication

lmalenfant commented 11 months ago

I'm merging these changes into your branch. There is a code smell but that is just the cognitive complexity on the nested loops which will hopefully get resolved when we move to the other code.