Feature/112 reconfigure the detectors to use global code for the binary serializers 2

[hayakawa16]

Creating a draft PR so it goes through all of the checks. Will add reviewers next week.

[lmalenfant]

@hayakawa16 The quality gate passed!

There are 11 new code smells, we can't fix them all (some are cognitive complexity with the factory code) but some of them can be fixed.

[hayakawa16]

Thanks Lisa! I will await dcuccia's review before proceeding.

[hayakawa16]

Just wanted to post that I took an infile that I ran with master on 10/12/23 and reran it using this branch. The results are identical! It was a sanity check suggested by lmalenfant and gives us more confidence in our code modifications.

[hayakawa16]

dcuccia, thank you for your review! I can easily modify the unit test names.

I like your ideas for future work. It always bothered me how many times a MC simulation is executed during the course of running the unit tests. If this could be optimized somehow, that would be great! In addition to your list, in our discussion on this issue we uncovered the need to analyze PopulateFromEnumerable and possibly update application to be column-major. Creating place holder issues for these features sounds good. Would you like to create them?

[sonarcloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
6 Code Smells

100.0% Coverage
8.9% Duplication