Feature/122 add ability to use layered concentric infinite cylinders with refractive index mismatch

[hayakawa16]

Hi, this is a draft of a PR so I can see file differences and make sure all looks good. I will assign reviewers when I'm ready for review.

[hayakawa16]

I'm ready for review.

[hayakawa16]

I just saw sonarcloud review. Give me a bit to address these.

[hayakawa16]

Okay I'm ready for review.

[hayakawa16]

Hi @lmalenfant, thanks for your review. I can make these edits.

[hayakawa16]

I have updated code and pushed.

On another topic. I pulled master and ran an infile that I ran in August 2023 and obtained identical results. Then I pulled this branch and ran the same infile. The results are not identical. I think they are statistically equivalent but not sure. I'd like to know for sure before I merge this branch into master.

[sonarcloud[bot]]

Quality Gate passed

Issues
2 New issues

Measures
0 Security Hotspots
85.7% Coverage on New Code
5.4% Duplication on New Code

See analysis details on SonarCloud

[lmalenfant]

I also noticed that we cannot merge right now because I made the master branch read only. We either have to force push or remove the lock. I checked that box so we can't push to master without a PR. I need to do more research to figure out the best protection.

[hayakawa16]

I've performed my analysis of results using master and this branch and they agree within variance.

[hayakawa16]

I feel okay about merging this into master. Should I check "Merge without waiting for requirements to be met (bypass branch protections)" and click "Merge pull request"?

[lmalenfant]

@hayakawa16 yes go ahead and merge, I think you just need to check the box and then the button will be available.