search

VirtualPhotonics / VTS

Virtual Tissue Simulator
https://virtualphotonics.org
Other
34 stars 9 forks source link

feature/139-address-deprecation-warning-when-building-vts-under-net-v6 #142

Closed lmalenfant closed 7 months ago

lmalenfant commented 7 months ago

@dcuccia I'm not sure if this is what you had in mind for removing the obsolete method, I tried other ways of implementing GetEnumerator() but this appeared to be the most straight-forward. If you have another suggestion, let me know.

sonarcloud[bot] commented 7 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

lmalenfant commented 7 months ago

@dcuccia, I did mention that to @hayakawa16 but my reasoning for leaving it this way was because we don't have any code that uses GetEnumerator() and so I wanted to leave the original code in place to show how it was implemented. We could add a unit test for validation and then move the code.

dcuccia commented 7 months ago

I see. Well, all uses of the IEnumerable interface "uses" it. But up to you, no biggie.