search

VirtualPhotonics / VTS

Virtual Tissue Simulator
https://virtualphotonics.org
Other
34 stars 9 forks source link

Bugfix/145 bug found in dmcdrofrhodmusdetector #146

Closed hayakawa16 closed 5 months ago

hayakawa16 commented 5 months ago

I think this is ready for review. @janakarana made a lot of simplifications to the code equation-wise. I simplified the code logic.

hayakawa16 commented 5 months ago

While fixing prior sonarcloud new issues, I've introduced 2 new issues. I think I need @lmalenfant advice on how to fix 2 new issues.

janakarana commented 5 months ago

While fixing prior sonarcloud new issues, I've introduced 2 new issues. I think I need @lmalenfant advice on how to fix 2 new issues.

I think you need to add "break;" after each case

sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.9% Coverage on New Code
4.2% Duplication on New Code

See analysis details on SonarCloud