search

VirtualPhotonics / VTS

Virtual Tissue Simulator
https://virtualphotonics.org
Other
34 stars 9 forks source link

Update prompt during Build #157

Open scottprahl opened 2 months ago

scottprahl commented 2 months ago

Describe the bug The build stops and asks

Press Enter to exit

This is ambiguous. I thought it the build would exit without completing. A slightly less ambiguous prompt might be

Build Complete. Press Enter to continue.

Application (MCCL, MATLAB or VTS code):

This seems to be in all the Build files. The Read-Host -Prompt lines are something like

Read-Host -Prompt "Press Enter to exit MATLAB release process"

To Reproduce

./BuildTestCore.ps1 ./BuildTestRelease.ps1 ./BuildTestReleaseMATLAB.ps1 ./BuildTestReleaseMCCL.ps1 ./BuildTestReleaseScripting.ps1

Expected behavior Less ambiguous prompt

Additional context Obviously not critical

lmalenfant commented 2 months ago

Hi Scott,

This is a great suggestion, these scripts (that were originally batch files) were written to create the release versions of the software and not specifically intended for end users. Seeing that you are using these scripts, we can definitely make them less ambiguous for an external user.