search

VirtualPhotonics / VTS

Virtual Tissue Simulator
https://virtualphotonics.org
Other
34 stars 9 forks source link

Modifications to correct code, validate, and test code and validation… #50

Closed hayakawa16 closed 2 years ago

hayakawa16 commented 2 years ago

… for bug that disallows user to specify pMCDiffuseTransmittance database.

hayakawa16 commented 2 years ago

Hi Lisa,

Good catch!! Yes, I'd like to fix it. Do I just modify it and push? Do I need to close pull request and reopen?

Thanks for your help! Carole

On 2022-09-29 13:38, Lisa Malenfant wrote:

@lmalenfant requested changes on this pull request.

Hi Carole,

It looks good, we should probably change that filename before we merge.

-- Reply to this email directly, view it on GitHub [1], or unsubscribe [2]. You are receiving this because you authored the thread.Message ID: @.***>

Links:

[1] https://urldefense.com/v3/__https://github.com/VirtualPhotonics/VTS/pull/50*pullrequestreview-1125969223__;Iw!!CzAuKJ42GuquVTTmVmPViYEvSg!LwN_r10AUD93eG5ChbEHVZa0HIDznIh9d1kU-3kMc8MwNpZ1Bkwy1VfmKhcbSKSMSBBxzgiLxP-Qm-0tz0rDOIXG$ [2] https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AGNQ7UZRZB4VX6DH5PHC6G3WAX447ANCNFSM6AAAAAAQZC2PRU__;!!CzAuKJ42GuquVTTmVmPViYEvSg!LwN_r10AUD93eG5ChbEHVZa0HIDznIh9d1kU-3kMc8MwNpZ1Bkwy1VfmKhcbSKSMSBBxzgiLxP-Qm-0tz26EYnrK$