search

VirtualPhotonics / VTS

Virtual Tissue Simulator
https://virtualphotonics.org
Other
34 stars 9 forks source link

Lm add unit tests and cleanup #56

Closed lmalenfant closed 1 year ago

lmalenfant commented 1 year ago

The unit tests are up to 100% and the code cleanup is done. I pulled in master and the .NET 4.8 unit tests run fine.

lmalenfant commented 1 year ago

What a extensive effort! Had questions about the use of "IReadOnlyList" (ComputationFactory line 87) compared to prior "Complex[]": have not come across IReadOnlyList before, why is it warranted and why change from array to IList?

It was a clean-up suggestion, probably one of the ones that prompted me to increase code coverage before making changes because I wanted to make sure it didn't break anything. I have used it before, it is my understanding that it is good to use "readonly" where possible because it makes the code more readable, another developer would know that the value will not change after it is set.