search

VirtualPhotonics / VTS

Virtual Tissue Simulator
https://virtualphotonics.org
Other
34 stars 9 forks source link

Add resiliency to CustomBinaryWriterOfT.cs by creating any required directories first #85

Closed dcuccia closed 1 year ago

dcuccia commented 1 year ago

Fixes #84

lmalenfant commented 1 year ago

I'm good with the changes, I would like to allow @hayakawa16 time to review and approve and then we are good to merge.

hayakawa16 commented 1 year ago

I have reviewed changes and all looks good to me.

dcuccia commented 1 year ago

I made those final changes for IDisposable, improved some null checks further, and fixed failing units tests. Ok to merge?

lmalenfant commented 1 year ago

Nice @dcuccia! Going above and beyond - It looks good, you are good to merge.

lmalenfant commented 1 year ago

@dcuccia please delete the branch once it is merged, you can use the button above.