Closed dcuccia closed 1 year ago
I put an upvote on this discussion, I probably should have made a comment also. If you would like to create a separate branch from master and make this change, we will be able to pull the Vts.Gui.Wpf into the solution to make sure the binding still works as expected.
Cool, thanks Lisa! I'm on it. :)
Cool, thanks Lisa! I'm on it. :)
Thank you!!
There are multiple failing unit tests in the VTS, MCCL and PP (192), is it possible that this has affected the serialization/deserialization. When we make changes like this to the library we have to run unit tests before we create the PR. I think this code change needs investigating more.
Ok, I'll take a look. Pretty sure this is a JSON.Net issue that I've fixed before. Sorry - was trying to get something out to you quickly yesterday.
Pushed the small fix (this one gets me every time). Sorry for the churn - I'm used to pushing my changes to my remote branch and getting build/test automatically done for me, which blocks PR creation in the first place.
(all tests passing now)
Thanks! Let me review it on the branch first before recreating the PR.
This was discussed in https://github.com/VirtualPhotonics/VTS/discussions/81 and is rearing it's head as I try to make the Notbooks simple and refactor commonly used code/extensions to the Vts core.