search

Virtuoel / Towelette

Fabric mod that allows for Waterlogging almost anything with any fluid
MIT License
13 stars 3 forks source link

Top face of fluids should be culled in some waterlogging cases #29

Closed muzikbike closed 4 years ago

muzikbike commented 4 years ago

With the following setup: 2020-06-27_21 48 36

the top faces of water and lava are still rendered, even though it's almost impossible to actually see them under normal conditions: 2020-06-27_21 48 58

It probably isn't really worth wasting effort on drawing these faces in the first place, since they can only be seen under very specific circumstances. Also mojang has done this before with certain cases, such as removing it from the bottom of blocks with full bottom faces in 1.15 and the sides of blocks with full faces on said sides in 1.16.

muzikbike commented 4 years ago

probably better to leave these kinds of rendering issues to sodium