search

VirtusLab-Open-Source / strapi-plugin-comments

A plugin for Strapi Headless CMS that provides end to end comments feature with their moderation panel, bad words filtering, abuse reporting and more.
MIT License
409 stars 64 forks source link

feat: [CU-2ep5xe1] [CU-2eap4ev] inform commenter about responses & avatar fix #143

Closed cyp3rius closed 2 years ago

cyp3rius commented 2 years ago

Ticket

https://github.com/VirtusLab/strapi-plugin-comments/issues/142 https://github.com/VirtusLab/strapi-plugin-comments/issues/139

Summary

What does this PR do/solve?

Introduces functionality of informing thread author about responses & fixes moderation panel crashing when avatar field of Strapi User is not media or relation.

Test Plan

  1. Run the app
  2. Add field avatar with type string to the User collection and create sample users
  3. Post a comment and couple responses to it
  4. See that moderation panel works (displays avatars) and you're receiving e-mails about responses (depends on your SMTP configuration)
cyp3rius commented 2 years ago

Task linked: CU-2eap4ev Inform commenter via mail about reply

cyp3rius commented 2 years ago

Task linked: CU-2ep5xe1 Moderation panel crashes when avatar field is not populable

codecov-commenter commented 2 years ago

Codecov Report

Merging #143 (19d999f) into master (c9aef97) will increase coverage by 0.15%. The diff coverage is 52.94%.

@@            Coverage Diff             @@
##           master     #143      +/-   ##
==========================================
+ Coverage   61.82%   61.97%   +0.15%     
==========================================
  Files           9        9              
  Lines         516      547      +31     
  Branches      201      210       +9     
==========================================
+ Hits          319      339      +20     
- Misses        194      205      +11     
  Partials        3        3
Flag Coverage Δ
unittest 61.97% <52.94%> (+0.15%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/services/admin.ts 5.17% <0.00%> (-1.44%) :arrow_down:
server/services/client.ts 86.01% <78.26%> (+2.40%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c9aef97...19d999f. Read the comment docs.