VirtusLab-Open-Source / strapi-plugin-comments

A plugin for Strapi Headless CMS that provides end to end comments feature with their moderation panel, bad words filtering, abuse reporting and more.
MIT License
413 stars 65 forks source link

Author populate task [CU-2zhvxrm] #170

Closed mkmak2 closed 2 years ago

mkmak2 commented 2 years ago

Ticket

https://github.com/VirtusLab/strapi-plugin-comments/issues/

Summary

author's name is populating in 3 different ways according on author's first name, last name and username blocks reports against admin comments *display shield icon on admin avatar

Test Plan

trying to send author's name in different ways compare reporting client comment and admin comment *create admin comment and client comment and see the difference in avatar display

codecov-commenter commented 2 years ago

Codecov Report

Merging #170 (dd179c7) into develop (c42d5af) will decrease coverage by 0.06%. The diff coverage is 75.00%.

@@             Coverage Diff             @@
##           develop     #170      +/-   ##
===========================================
- Coverage    79.46%   79.39%   -0.07%     
===========================================
  Files           31       31              
  Lines          823      830       +7     
  Branches       273      276       +3     
===========================================
+ Hits           654      659       +5     
- Misses         166      168       +2     
  Partials         3        3              
Flag Coverage Δ
unittest 79.39% <75.00%> (-0.07%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
content-types/comment.ts 100.00% <ø> (ø)
server/services/admin.ts 76.79% <ø> (ø)
server/services/client.ts 85.51% <66.66%> (-0.50%) :arrow_down:
server/services/utils/functions.ts 76.92% <80.00%> (+0.21%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

cyp3rius commented 2 years ago

Task linked: CU-2zhvxrm Admin data and indicator not populated via API