VirtusLab-Open-Source / strapi-plugin-comments

A plugin for Strapi Headless CMS that provides end to end comments feature with their moderation panel, bad words filtering, abuse reporting and more.
MIT License
405 stars 63 forks source link

[CU-862hz23aa] UI / Label Rendering Issue? #180

Closed rroline closed 1 year ago

rroline commented 1 year ago

Hello!

I followed the installation instructions and after running yarn build the plugin appeared, but seems to have issue with rendering the values associated with the various plugin fields. Did I miss a critical configuration step? The plugin does not appear to be functional either.

I am running a custom docker image of strapi v4.5.3 and node 14.21.2. All packages/modules were installed using yarn. Any help would be greatly appreciated. Thanks!

image

Antontsyk commented 1 year ago

Hello! I have same issue also. "dependencies": { "@_sh/strapi-plugin-ckeditor": "^1.1.2", "@strapi/plugin-i18n": "4.5.4", "@strapi/plugin-users-permissions": "4.5.4", "@strapi/strapi": "4.5.4", "better-sqlite3": "7.6.2", "pg": "^8.8.0", "pg-connection-string": "^2.5.0", "sharp": "^0.31.2", "strapi-middleware-cache": "^2.1.8", "strapi-middleware-upload-plugin-cache": "^2.1.0", "strapi-plugin-comments": "^2.2.3", "strapi-plugin-custom-api": "^1.0.3", "strapi-plugin-fuzzy-search": "^1.10.2", "strapi-plugin-import-export-entries": "^1.18.0", "strapi-plugin-local-image-sharp": "^1.2.1", "strapi-plugin-rest-cache": "^4.2.5", "strapi-plugin-sitemap": "^2.0.8", "strapi-plugin-transformer": "^2.1.1", "strapi-provider-rest-cache-memory": "^4.2.5" },

Снимок экрана 2022-12-27 в 00 57 34
cyp3rius commented 1 year ago

@Antontsyk @rroline may I ask you both to verify if you've got the translation file properly placed within the plugin package in node_modules? Also the console logs would be appreciated as by doing same steps I cannot reproduce that bug.

Antontsyk commented 1 year ago
Снимок экрана 2022-12-27 в 20 53 10

@cyp3rius

rroline commented 1 year ago

I am running this in docker so the files are automatically installed from the repo when i run yarn build. The translation files are present in the plugin folder after installation.

image

rroline commented 1 year ago

@cyp3rius - Which logs are you looking for? The build logs when installing the plugin package? The build logs from starting the strapi image? Or the console logs when that module/plugin is accessed?

I looked in all three places and didnt see anything that jumped out at me, but I am happy to send whatever you think would help. Thanks!

Jahorse commented 1 year ago

I'm having the same issue with similar dependencies. I also see en.json, fr.json, and pt-BR.json in the translations folder and I don't have any related messages in the JS debugger console when I visit http://localhost:1337/admin/settings/comments.

How is the language supposed to get set for the plugin? I haven't seen any documentation about how to set which translation file to use.

Bodokh commented 1 year ago

I am using node 16 with strapi 4.4.3 with the latest comments package also running into the same issue

cyp3rius commented 1 year ago

Thank you all for the details. Digging into that and hope today to provide a hotfix once I'll reproduce the behavior.

cyp3rius commented 1 year ago

Fix is ready, should be reviewed and released today. Mostly it started to happen with some combination of plugins installed (maybe number, not sure), the async execution been scheduled and didn't executed in time of bootstrap.

cyp3rius commented 1 year ago

Fixed in 2.2.4

LeoMoshko commented 1 year ago

@cyp3rius Hi Mateusz, Unfortunately it broke for the case when there is a different language than there are translations. My issues was that by adding a custom locale while the plugin is active, the loadTrads method was throwing an error. This was in my case due to the fact that the plugin only supports the following languages: en, fr, tr and "pt-BR".

cyp3rius commented 1 year ago

Will consider than a fallback language if Strapi don't do that automatically.