search

VirtusLab-Open-Source / strapi-plugin-comments

A plugin for Strapi Headless CMS that provides end to end comments feature with their moderation panel, bad words filtering, abuse reporting and more.
MIT License
413 stars 65 forks source link

fix: [CU-862hz23aa] Translations init failure while async loading #181

Closed cyp3rius closed 1 year ago

cyp3rius commented 1 year ago

Ticket

https://github.com/VirtusLab/strapi-plugin-comments/issues/180

Summary

What does this PR do/solve?

Solves failure for async loading of translations. Method has been changed to synchronous.

Test Plan

  1. Run the app
  2. See that translations are loading properly
cyp3rius commented 1 year ago

Task linked: CU-862hz23aa Translations init failure

codecov-commenter commented 1 year ago

Codecov Report

Merging #181 (bdfe931) into master (ccd9dc3) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #181   +/-   ##
=======================================
  Coverage   79.36%   79.36%           
=======================================
  Files          34       34           
  Lines         882      882           
  Branches      292      294    +2     
=======================================
  Hits          700      700           
  Misses        179      179           
  Partials        3        3
Flag Coverage Δ
unittest 79.36% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
admin/src/utils/getMessage.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.