search

VirtusLab-Open-Source / strapi-plugin-navigation

A plugin for Strapi Headless CMS that provides navigation / menu builder feature with their possibility to control the audience and different output structure renderers like (flat, tree and RFR - ready for handling by Redux First Router)
MIT License
308 stars 57 forks source link

I've updated strapi version and the plugin now doesn't work like before #341

Closed diegobaratta closed 1 year ago

diegobaratta commented 1 year ago

As the title says, I was working with this plugin then I've updated my strapi from v4.8 to v4.10. I've ran "yarn" command and "yarn build" too already but the plugin doesn't work like before. I've configured it to take my Content Type's title and slug by default when I didn't write anything on Title and URL fields, but now if I leave'em blank, it claims that I should write something instead of taking the default values.

imagen imagen

cyp3rius commented 1 year ago

Checking on v4.10

diegobaratta commented 1 year ago

Is there some news?

cyp3rius commented 1 year ago

I was able to reproduce your case with 2 versions of 4.10.x (not sure why). Anyway working on the solution, seems like a validation lib changes.

Raesta commented 1 year ago

same problem here, o you have plan for fix this bug ?

Ok i've the solution, i will provide a pull request quickly !

PR: https://github.com/VirtusLab-Open-Source/strapi-plugin-navigation/pull/344

cyp3rius commented 1 year ago

You was quicker than me :) Will review your PR tonight and release the version with fix. Thank you for contribution!

cyp3rius commented 1 year ago

Version 2.2.9 published with @Raesta fix. Thanks!

diegobaratta commented 1 year ago

@cyp3rius Thanks for the effort to fix this, it's appreciated. The default slug now works fine, like before, but it doesn't take the default title yet. In fact, if you don't write anything on the title field and hit save, instead of take the default content type's title as configured, nothing happens. Not even an error, it just stays stuck there till you write some title.

I'm working with Strapi v4.10.5, didn't tried with new 4.10.6 yet...

graphicfox commented 1 year ago

@cyp3rius Same Problem like @diegobaratta has.