search

VirtusLab-Open-Source / strapi-plugin-navigation

A plugin for Strapi Headless CMS that provides navigation / menu builder feature with their possibility to control the audience and different output structure renderers like (flat, tree and RFR - ready for handling by Redux First Router)
MIT License
318 stars 58 forks source link

Internationalization issue is not fixed #396

Closed oliynykroman closed 9 months ago

oliynykroman commented 11 months ago

After previous fix. I had new issue. How to reproduce:

  1. Update plugin.
  2. Add new language in settings > Internationalization
  3. Log out, login
  4. Add new navigation menu.
  5. Prev menu got lost one language and get new All menu items just destroys :( . New menu will get first and last language. Each next menu got strange language relations image

As i see the issue is in menu language relations table. Also removed EN language, but on DB i still see deleted locale: image

CodeVoyager commented 11 months ago

Hi @oliynykroman Did you restart strapi server after adding new language version to the Strapi? On server bootstrap these kind of issues should be resolved. If these issues persist after server restart we will need to look deeper into the issue.

We're sorry for your inconvenience.

oliynykroman commented 11 months ago

Hi @CodeVoyager Yes, i did. Also made build. I made short video with issue: How to reproduce:

  1. Had some menu with two languages versions (for ex. Header)
  2. Added new language.
  3. Logged out, Restarted server, made build.
  4. Logged in admin. See bugs like in video.

Also remove some internationlization doesn't affect locales in DB

https://github.com/VirtusLab-Open-Source/strapi-plugin-navigation/assets/29798653/043f5ca5-8ffa-4596-93b2-79d875ffa90c

CodeVoyager commented 9 months ago

Hi @oliynykroman,

Hopefully this will be the last of i18n issues. There's a PR to cover issues mentioned by you.

FYI: Navigations are not deleted from DB when locale version is disabled in admin panel, by design. We debated that decision and decided that locale version change is easy to made by hard to revert. If anyone needs those items removed it can be easily done by SQL query. We are open for discussion though.

cyp3rius commented 9 months ago

Released as part of 2.4.0.