codecov[bot]
commented
6 months ago Codecov Report
Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.
Project coverage is 53.58%. Comparing base (
0f9934f) to head (0b10a16).
| Files | Patch % | Lines |
|---|---|---|
| server/services/admin.ts | 80.00% | 1 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #425 +/- ## ========================================== + Coverage 51.83% 53.58% +1.74% ========================================== Files 31 31 Lines 1115 1116 +1 Branches 332 333 +1 ========================================== + Hits 578 598 +20 + Misses 534 515 -19 Partials 3 3 ``` | [Flag](https://app.codecov.io/gh/VirtusLab-Open-Source/strapi-plugin-navigation/pull/425/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=VirtusLab-Open-Source) | Coverage Δ | | |---|---|---| | [unittest](https://app.codecov.io/gh/VirtusLab-Open-Source/strapi-plugin-navigation/pull/425/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=VirtusLab-Open-Source) | `53.58% <80.00%> (+1.74%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=VirtusLab-Open-Source#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Ticket
https://github.com/VirtusLab-Open-Source/strapi-plugin-navigation/issues/424
Summary
What does this PR do/solve?
context: If a navigation has no items
$orusing an empty list results in all table rows to be included.Test Plan