Loosen up and fix URN parsing

[lbialy]

Fixes #387 by allowing more permissive parsing of URNs coming from engine and adhering to 'string' spec in regard to it being any string without double colons.

[dubinsky]

@lbialy

adhering to 'string' spec in regard to it being any string without double colons.

Not that I need them, but what is wrong with double colons in the resourceName? ;)

[lbialy]

It turns out that for URNs not to match spec is not a big deal for Pulumi as they basically turned resource name into (?s:.*), so yes, it seems that they did not validate resource names so hard that now they have to support newlines in them. We could mirror that (and we do, for stuff coming from engine) but I would like to preserve a bit of sanity in resource names mostly because I'm convinced that: a) somebody will or already did implement a parser that partitions by :: and additional out of spec double colons will trip it b) newlines in resource names are not escaped in cli and will break tui

Also, ocd. There's a spec. Let's be predictable and respect the spec.

On Mon 12. Feb 2024 at 20:10, Leonid Dubinsky @.***> wrote:

@lbialy https://github.com/lbialy

adhering to 'string' spec in regard to it being any string without double colons.

Not that I need them, but what is wrong with double colons in the resourceName? ;)

— Reply to this email directly, view it on GitHub https://github.com/VirtusLab/besom/pull/389#issuecomment-1939367011, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACBVNUT4NPGZXX7OFKG4XH3YTJSK5AVCNFSM6AAAAABDE5MBS6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZZGM3DOMBRGE . You are receiving this because you were mentioned.Message ID: @.***>

[dubinsky]

I'm convinced that: a) somebody will or already did implement a parser that partitions by :: and additional out of spec double colons will trip it

I agree: if I was writing a proper parser, that's how I would start ;)

Also, ocd. There's a spec. Let's be predictable and respect the spec.

100%