search

VirtusLab / besom

Besom - a Pulumi SDK for Scala. Also, incidentally, a broom made of twigs tied round a stick. Brooms and besoms are used for protection, to ward off evil spirits, and cleansing of ritual spaces.
https://virtuslab.github.io/besom/
Apache License 2.0
113 stars 7 forks source link

Set assumedEvictionErrorLevel to Level.Error #487

Closed jchapuis closed 1 month ago

jchapuis commented 1 month ago

There is an intrinsic eviction warning in the latest build of besom-core with com.lihaoyi:sourcecode . pprint depends on 0.2.7 while besom-core depends on 0.3.1.

Setting assumedEvictionErrorLevel := Level.Error should help in surfacing these issues.

lbialy commented 1 month ago

Interesting. We use scala-cli to build the whole thing and it didn't catch it, apparently.

jchapuis commented 1 month ago

Yes so this is actually quite problematic for us as we are using sbt with strict eviction avoidance. Because of this intrinsic compatibility issue in the library, in all projects using besom we have to add libraryDependencySchemes += "com.lihaoyi" %% "sourcecode" % "always"

lbialy commented 1 month ago

Would a quickfix release of 0.3.2 with correct dependency tree help?

lbialy commented 1 month ago

@Gedochao are you aware if scala-cli has any way to prevent eviction-related issues like this? Docs are silent on this topic.

jchapuis commented 1 month ago

@lbialy maybe I should have answered directly, yes a quickfix release would help as right now this libraryDependencySchemes is propagating throughout our repos 🙂

lbialy commented 1 month ago

For reference: the only way to validate this, for now, is to use scala-cli export . --sbt in core and then sbt evicted in dest directory. This shows possible versioning problems. I have fixed them manually in #500.

lbialy commented 1 month ago

fixed in #500, will release 0.3.2 momentarily

lbialy commented 2 weeks ago

@jchapuis I have released 0.3.2-SNAPSHOT (sonatype snapshot repo) today, could you please verify that it solves this issue for you? I will release complete 0.3.2 version once you confirm it does indeed solve your issues.

jchapuis commented 2 weeks ago

@lbialy thanks! I can confirm it works 🎉