VirtusLab / besom

Besom - a Pulumi SDK for Scala. Also, incidentally, a broom made of twigs tied round a stick. Brooms and besoms are used for protection, to ward off evil spirits, and cleansing of ritual spaces.
https://virtuslab.github.io/besom/
Apache License 2.0
113 stars 7 forks source link

Fix issue 489 - trace level messages get evaluated to send to Pulumi engine #492

Closed lbialy closed 1 month ago

lbialy commented 1 month ago

Fansi has some issues with some ansi escape codes as reported in #489. This does not fix the inner issue, we just stop sending trace log events to the engine and that prevents evaluation of the lines that cause the problem. Alternative would be to stop using pprint/fansi combo for debug but that would make debugging experience much worse so no go.

Therefore this is fixed for the end user, weird fansi (?) bug persists on trace level and can / will come back to bite us in debugging.

lbialy commented 1 month ago

Changed it so that no trace level messages get sent to pulumi engine. Temporary solution.

lbialy commented 1 month ago

Found a solution that actually works. No need for half-assed temporary solutions.