Keyboard shortcuts for actions only work when Git Machete tool window is open

[PawelLipski]

Otherwise, the DataContext passed in ActionEvent points to IdeFrameImpl, not to our own com.virtuslab.gitmachete.frontend.ui.impl.table.EnhancedGraphTable, and hence the things like GitMacheteRepositorySnapshot aren't available to the action, which then gets disabled via com.virtuslab.gitmachete.frontend.actions.base.BaseGitMacheteRepositoryReadyAction#onUpdate.

Naive (maybe correct?) solution: instead of relying on constructs like anActionEvent.getData(DataKeys.GIT_MACHETE_REPOSITORY_SNAPSHOT), instead use com.virtuslab.gitmachete.frontend.ui.services.GraphTableService? and then use getGitMacheteRepositorySnapshot() on the graph table instance?

[PawelLipski]

The naive solution is just to do sth like:

--- a/frontend/actions/src/main/java/com/virtuslab/gitmachete/frontend/actions/expectedkeys/IExpectsKeyGitMacheteRepository.java
+++ b/frontend/actions/src/main/java/com/virtuslab/gitmachete/frontend/actions/expectedkeys/IExpectsKeyGitMacheteRepository.java
@@ -8,13 +8,16 @@ import com.virtuslab.branchlayout.api.BranchLayout;
 import com.virtuslab.gitmachete.backend.api.IGitMacheteRepositorySnapshot;
 import com.virtuslab.gitmachete.backend.api.IManagedBranchSnapshot;
 import com.virtuslab.gitmachete.frontend.actions.base.IWithLogger;
-import com.virtuslab.gitmachete.frontend.datakeys.DataKeys;
+import com.virtuslab.gitmachete.frontend.ui.services.GraphTableService;

 public interface IExpectsKeyGitMacheteRepository extends IWithLogger {
   default @Nullable IGitMacheteRepositorySnapshot getGitMacheteRepositorySnapshot(AnActionEvent anActionEvent) {
-    IGitMacheteRepositorySnapshot gitMacheteRepositorySnapshot = anActionEvent != null
-        ? anActionEvent.getData(DataKeys.GIT_MACHETE_REPOSITORY_SNAPSHOT)
-        : null;
+    val project = anActionEvent.getProject();
+    if (project == null) {
+      return null;
+    }
+    val graphTable = project.getService(GraphTableService.class).getGraphTable();
+    val gitMacheteRepositorySnapshot = graphTable.getGitMacheteRepositorySnapshot();
     if (isLoggingAcceptable() && gitMacheteRepositorySnapshot == null) {
       log().warn("Git Machete repository snapshot is undefined");
     }

[PawelLipski]

But there are other things to be considered:

• [ ] is the result getGitMacheteRepositorySnapshot() always up to date when git machete tab is closed? if not (since IIRC the updates stop once the tab is no longer visible), then should the updates to repository snapshot happen even when the tab is closed? or maybe, the repository snapshot should be recomputed when it's needed while the tab is closed?
• [ ] should the git machete tab be opened first when the action while the tab is closed? this would solve/mitigate the problem with stale repository snapshot
• [ ] should the other custom data keys (see com.virtuslab.gitmachete.frontend.datakeys.DataKeys) be factored away this way as well)?