Open riponbanik opened 3 years ago
It should be possible to override the sleep time in a config file, it is not an advertised feature at the moment, but it exists, you can pass --config
param.
TODO:
--config
and the config schemaI've added --loop-sleep-time
flag, will release a version soon.
@pawelprazak Thanks. So need to pass this as args in deployment manifest?
yes, adding flags to the manifest on the args field, should work
Entrypoint in the Dockerfile is set to kubedrainer serve, and k8s translates this to the command field in the manifest, so yeah, adding flags to args in manifest should work
Hello all - we ran into an issue setting this flag in our Kubernete's manifest and found that the flag value is being set but not passed through to the running container parsed settings properly, see output of debug logs below (removed sensitive information as necessary):
The container args are being set as follows:
- name: kubedrainer
image: quay.io/virtuslab/kubedrainer:v0.0.10
args: ["--debug", "--loop-sleep-time", "60s"]
Let us know how we can properly override this value and if there is any other information that we can provide. Thank you!
After a bit more testing/digging... It looks like the option parsing issue was fixed in #14. A new release -- 0.0.11 or whatever -- needs to be made before the option will work as expected.
Is there way to reduce the api call limit to prevent the following? It looks like sleep time is 10s, so every minute it makes 6 api calls.
W0207 23:20:14.956666 1 handler.go:28] Can not get instance status and auto scaling group name, will try again: Throttling: Rate exceeded status code: 400, request id: e29ab693-33b8-401a-b73a-85567b8559bd