VirtusLab / scala-cli

Scala CLI is a command-line tool to interact with the Scala language. It lets you compile, run, test, and package your Scala code (and more!)
https://scala-cli.virtuslab.org
Apache License 2.0
554 stars 129 forks source link

`test` does not exit when finished when using munit-cats-effect #2623

Open davisuga opened 11 months ago

davisuga commented 11 months ago

Version(s) 1.1.0

Describe the bug scala-cli test does not exit if munit-cats-effect is being used.

To Reproduce Clone https://github.com/davisuga/testIssueRepro Run scala-cli test .

Expected behavior Exit when the test finishes

SethTisue commented 11 months ago

@mpilquist any insight into the cause, or suggestion on who else we might summon?

tgodzik commented 11 months ago

Could this be connected to https://github.com/scalameta/munit/issues/540 ?

armanbilge commented 11 months ago

https://github.com/davisuga/testIssueRepro/blob/742d9b19b4fcab63b7b4a8ce230660584f1320c4/spec.test.scala#L1-L2

//> using test.dep "org.scalameta::munit:0.7.29"
//> using test.dep "org.typelevel::munit-cats-effect:2.0.0-M1"

These are old and actually incompatible versions. The latest are

//> using test.dep "org.scalameta::munit:1.0.0-M10"
//> using test.dep "org.typelevel::munit-cats-effect:2.0.0-M4"

If you want to use the (unsupported?) munit 0.7.x series then please use:

//> using test.dep "org.scalameta::munit:0.7.29"
//> using test.dep "org.typelevel::munit-cats-effect-3:1.0.7"

@ scala-cli maintainers: can we get eviction warnings here? @ toolkit maintainers: can we please just release munit 1.0.0?

SethTisue commented 11 months ago

toolkit maintainers: can we please just release munit 1.0.0?

ticket: https://github.com/scalameta/munit/issues/647

scala-cli maintainers: can we get eviction warnings here?

ticket: https://github.com/VirtusLab/scala-cli/issues/1927

armanbilge commented 11 months ago