VirtusLab / scala-cli

Scala CLI is a command-line tool to interact with the Scala language. It lets you compile, run, test, and package your Scala code (and more!)
https://scala-cli.virtuslab.org
Apache License 2.0
542 stars 128 forks source link

virtuslab/scala-cli-setup@main is not allowed to be used in apache/incubator-pekko #2706

Open He-Pin opened 7 months ago

He-Pin commented 7 months ago
[Error: .github#L1](https://github.com/apache/incubator-pekko/commit/0ec41cd65d4375ced3c0d51a22eea1ef46eacebf#annotation_17363092704)
virtuslab/scala-cli-setup@main is not allowed to be used in apache/incubator-pekko. Actions in this workflow must be: within a repository owned by apache, created by GitHub, verified in the GitHub Marketplace, or matching the following: */*@[a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9]+, AdoptOpenJDK/install-jdk@*, JamesIves/github-pages-deploy-action@5dc1d5a192aeb5ab5b7d5a77b7d36aea4a7f5c92, TobKed/label-when-approved-action@*, actions-cool/issues-helper@*, actions-rs/*, al-cheb/configure-pagefile-action@*, amannn/action-semantic-pull-request@*, apache/*, burrunan/gradle-cache-action@*, bytedeco/javacpp-presets/.github/actions/*, chromaui/action@*, codecov/codecov-action@*, conda-incubator/setup-miniconda@*, container-tools/kind-action@*, container-tools/microshift-action@*, dawidd6/action-download-artifact@*, delaguardo/setup-graalvm@*, docker://jekyll/jekyll:*, docker://pandoc/core:2.9, eps1lon/actions-label-merge-conflict@*, gaurav-nelson/github-action-markdown-link-c...

refs: https://github.com/apache/incubator-pekko/actions/runs/7684337948

Gedochao commented 7 months ago

@He-Pin I don't have the access to the full log of the workflow, so I don't know what step it exactly fails on, and thus, can't inspect the exact check for the actions allowed in the repo. Some context may be helpful, it's the first time I see this check.

However, why are you using virtuslab/scala-cli-setup@main? I wonder if a GitHub Marketplace approved tag would fix this. Have you tried using virtuslab/scala-cli-setup@v1?

If I don't know the exact requirements of this check, it's hard to guess what could be done with this... it seems it mostly allows the use of Apache org actions and GitHub verified partner orgs' actions, fulfilling neither of which is realistic for Scala CLI (at least to my knowledge).

That being said, I can see apache/incubator-pekko using things like coursier/cache-action@v6.4.0, so perhaps it's the matter of whitelisting the Scala CLI action somewhere in the repo.

He-Pin commented 7 months ago

@Gedochao I have updated to : https://github.com/apache/incubator-pekko/blob/main/.github/workflows/nightly-builds.yml

Has no idea why I can't use the action.