search

VirtusLab / scala-cli

Scala CLI is a command-line tool to interact with the Scala language. It lets you compile, run, test, and package your Scala code (and more!)
https://scala-cli.virtuslab.org
Apache License 2.0
551 stars 129 forks source link

improvement: Use distinct on ScalacOpt #3139

Closed tgodzik closed 2 months ago

tgodzik commented 2 months ago

I am still getting an issue with multiple same plugin options and my guess is that the distinct doesn't work, especially that it is hard to figure out what can actually be contained there. Moving distinct to the end should be a much safer option.

Related to https://github.com/VirtusLab/scala-cli/issues/2708

Gedochao commented 2 months ago

I mean, sure, but I'm not sure if this really changes much. @tgodzik do we have a reproduction of the double plugin flag, so that we could add a test?

lbialy commented 2 months ago

I can test this immediately as besom compiler plugin breaks any scala-cli build, how can I download a nightly version of scala-cli?

tgodzik commented 2 months ago

scala-cli --cli-version nightly setup-ide . should do it, but I don't think the nightly is up yet