Metadata Fetching freezes on certain images

Virus-Axel / godot-solana-sdk

Build Solana games with godot. This GDExtension will enable godot to make on-chain and Solana integrated games.

MIT License

38 stars 12 forks source link

Metadata Fetching freezes on certain images #188

Closed ZenRepublic closed 4 months ago

ZenRepublic commented 7 months ago

Description

Usually, and error is throw immediately, but with certain nfts (mostly scam ones) fetching metadata stops the entire process for a very long time before error is returned

this one for example: https://ipfs.io/ipfs/bafkreihpa6rnq2bcog7lmxtzx2wzaiaaxu2o7ardfwmyhuepnht3ctjn6y

Suggested Improvements

maybe add a 5 second timeout or something?

Extra Information

No response

Virus-Axel commented 4 months ago

Timeout property added to SolanaClient. MetadataNode can now access SolanaClient properties.