Fails to build

[fvcr]

Hello,

The c-vtapi was included in Debian on 2022-02-14 and recently failed during build due to some functions involving curl.

In the files lib/VtUrl.c, lib/VtComments.c and lib/VtFile.c I found the function curl_formadd, could you replace it with curl_mime_init()?

There are other errors that can be seen at: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1027611

Thanks for your work with c-vtapi!

[fvcr]

Thanks for the changes, I tried to build it but the following errors persist (hope this helps, thanks!):

iVtComments.c: In function ‘VtComments_add’: VtComments.c:183:3: error: ‘curl_formadd’ is deprecated: since 7.56.0. Use curl_mime_init() [-Werror=deprecated-declarations] 183 | ret = curl_formadd(&formpost, | ^~~ In file included from VtComments.c:39: /usr/include/x86_64-linux-gnu/curl/curl.h:2570:1: note: declared here 2570 | curl_formadd(struct curl_httppost httppost, | ^~~~ VtComments.c:185:22: error: ‘CURLFORM_COPYNAME’ is deprecated: since 7.56.0. Use curl_mime_name() [-Werror=deprecated-declarations] 185 | CURLFORM_COPYNAME, "resource", | ^~~~~ /usr/include/x86_64-linux-gnu/curl/curl.h:2495:3: note: declared here 2495 | CURLFORM_COPYNAME CURL_DEPRECATED(7.56.0, "Use curl_mime_name()"), | ^~~~~ VtComments.c:186:22: error: ‘CURLFORM_COPYCONTENTS’ is deprecated: since 7.56.0. Use curl_mime_data() [-Werror=deprecated-declarations] 186 | CURLFORM_COPYCONTENTS, vt_comments->resource, | ^~~~~ /usr/include/x86_64-linux-gnu/curl/curl.h:2498:3: note: declared here 2498 | CURLFORM_COPYCONTENTS CURL_DEPRECATED(7.56.0, "Use curl_mime_data()"), | ^~~~~ VtComments.c:192:3: error: ‘curl_formadd’ is deprecated: since 7.56.0. Use curl_mime_init() [-Werror=deprecated-declarations] 192 | ret = curl_formadd(&formpost, | ^~~ /usr/include/x86_64-linux-gnu/curl/curl.h:2570:1: note: declared here 2570 | curl_formadd(struct curl_httppost httppost, | ^~~~ VtComments.c:194:22: error: ‘CURLFORM_COPYNAME’ is deprecated: since 7.56.0. Use curl_mime_name() [-Werror=deprecated-declarations] 194 | CURLFORM_COPYNAME, "comment", | ^~~~~ /usr/include/x86_64-linux-gnu/curl/curl.h:2495:3: note: declared here 2495 | CURLFORM_COPYNAME CURL_DEPRECATED(7.56.0, "Use curl_mime_name()"), | ^~~~~ VtComments.c:195:22: error: ‘CURLFORM_COPYCONTENTS’ is deprecated: since 7.56.0. Use curl_mime_data() [-Werror=deprecated-declarations] 195 | CURLFORM_COPYCONTENTS, comment, | ^~~~~ /usr/include/x86_64-linux-gnu/curl/curl.h:2498:3: note: declared here 2498 | CURLFORM_COPYCONTENTS CURL_DEPRECATED(7.56.0, "Use curl_mime_data()"), | ^~~~~ VtComments.c:200:3: error: ‘curl_formadd’ is deprecated: since 7.56.0. Use curl_mime_init() [-Werror=deprecated-declarations] 200 | ret = curl_formadd(&formpost, | ^~~ /usr/include/x86_64-linux-gnu/curl/curl.h:2570:1: note: declared here 2570 | curl_formadd(struct curl_httppost *httppost, | ^~~~ VtComments.c:202:22: error: ‘CURLFORM_COPYNAME’ is deprecated: since 7.56.0. Use curl_mime_name() [-Werror=deprecated-declarations] 202 | CURLFORM_COPYNAME, "apikey", | ^~~~~ /usr/include/x86_64-linux-gnu/curl/curl.h:2495:3: note: declared here 2495 | CURLFORM_COPYNAME CURL_DEPRECATED(7.56.0, "Use curl_mime_name()"), | ^~~~~ VtComments.c:203:22: error: ‘CURLFORM_COPYCONTENTS’ is deprecated: since 7.56.0. Use curl_mime_data() [-Werror=deprecated-declarations] 203 | CURLFORM_COPYCONTENTS, vt_comments->api_key, | ^~~~~ /usr/include/x86_64-linux-gnu/curl/curl.h:2498:3: note: declared here 2498 | CURLFORM_COPYCONTENTS CURL_DEPRECATED(7.56.0, "Use curl_mime_data()"), | ^~~~~ VtComments.c:254:5: error: ‘curl_formfree’ is deprecated: since 7.56.0. Use curl_mime_free() [-Werror=deprecated-declarations] 254 | curl_formfree(formpost); // cleanup the formpost chain | ^~~~~ /usr/include/x86_64-linux-gnu/curl/curl.h:2606:1: note: declared here 2606 | curl_formfree(struct curl_httppost form); | ^~~~~

[mgmacias95]

Hello, can you try building again? It should raise no warnings now.

[fvcr]

Hello, can you try building again? It should raise no warnings now.

Hello, I tried to build again and was raised warnings.

I have attached the build log file, you can see the warnings from line 567 onwards.

Thanks!

[mgmacias95]

Hello @fvcr,

I have addressed the warnings shown on the log file. Most of them were already addressed though, which made me feel you were not compiling the version in the curl_update_22 branch. Can you check it out again?

Thanks!

[fvcr]

Hi @mgmacias95, Yes, I used the default branch, I was able to compile it using the curl_update_22 branch!

Thanks!

[mgmacias95]

Thank you! :)