VirusTotal / yara-python

The Python interface for YARA
http://virustotal.github.io/yara/
Apache License 2.0
650 stars 179 forks source link

Version 4.3 cannot be installed on Virtual Machines #229

Closed JAlbert2 closed 10 months ago

JAlbert2 commented 1 year ago

I am running two virtual machines, Windows 10 Education and Ubuntu 22.04, and neither can install yara-python 4.3. Both can install 4.2.3 with the pip command, but the most recent version fails. I have attached the terminal output for the Ubuntu VM. It is a fresh install of Ubuntu with the only extra python packages being refile, capstone>=3.0.5, pycryptodome, and leechcorepyc>=2.4.0. error-log.txt

SonOfLilit commented 1 year ago

This is the error I'm seeing (on docker.io/library/python:3.10-slim@sha256:7b0a5cefbcdd085faa21533c21549e55a7e66f5aed40f8d1f4de13a017e352cd on https://github.com/actions/runner-images/releases/tag/ubuntu22%2F20230326.2):

#14 21.22       yara/libyara/modules/pe/authenticode-parser/authenticode.c:22:10: fatal error: openssl/asn1.h: No such file or directory
#14 21.22          22 | #include <openssl/asn1.h>
#14 21.22             |          ^~~~~~~~~~~~~~~~
#14 21.22       compilation terminated.
#14 21.22       error: command '/usr/bin/gcc' failed with exit code 1

This seems to be caused by the addition of unqualified #include <libssl/asn1.h>s in https://github.com/VirusTotal/yara/commit/b9cd46df15d7345ca52f86e7794f97098d496d22 (as you can see in the diff, before they were all protected by #if HAVE_LIBCRYPTO) and might be somehow related to https://github.com/VirusTotal/yara-python/issues/17?

lampnout commented 1 year ago

In my opinion, the key to this error is the line:

fatal error: openssl/asn1.h: No such file or directory

This error indicates that libssl is missing.

On a Linux distro you can install libssl-dev with the command:

apt install libssl-dev

Hopefully, this resolves the issues and allows installation.

plusvic commented 10 months ago

Fixed in https://github.com/VirusTotal/yara-python/commit/b41b628c3011904f3e178a5dfa8a17dca6efb0a0