search

VirusTotal / yara-python

The Python interface for YARA
http://virustotal.github.io/yara/
Apache License 2.0
637 stars 178 forks source link

Pass build parameters correctly, enable dex and macho modules #256

Closed foundkey closed 3 months ago

foundkey commented 3 months ago

Fix for #254

According to the discussion under this PR, build parameters should be added via the setup.cfg file.

Enabling modules cuckoo and magic requires the build machine to install additional libraries. To avoid major CI changes, keep them disabled.

The openssl part will be automatically enabled based on whether there is openssl in the build environment, so there is no need to configure and enable it. If oepnssl is manually configured and enabled, an error will occur when building the -macosx_universal2 wheel. Because the macos build environment cannot provide the arm version of openssl dependent libraries. Due to parameter passing issues in previous builds, the -macosx_universal2 version of the package did not enable openssl and did not include the hash module.

I kept the -macosx_universal2 version of the build, but it still doesn't have openssl enabled, and it still doesn't include the hash module. This may cause confusion for arm64 macos users, so according to #253 , a build of sdist was added. This allows advanced users to use local build installations if necessary.

In addition, according to the instructions in the CI log: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/ I upgraded the version of docker/setup-qemu-action.

google-cla[bot] commented 3 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.