VirusTotal / yara

The pattern matching swiss knife
https://virustotal.github.io/yara/
BSD 3-Clause "New" or "Revised" License
7.93k stars 1.42k forks source link

modules/pe/authenticode: Add Wincrypt API support for authenticode on Windows #2053

Closed lucas-soares-npro closed 1 month ago

lucas-soares-npro commented 3 months ago

Hi,

In the context of a Stormshield internal project, we could not use OpenSSL in libyara. Due to this fact, we developped an alternate version of authenticode parser using only Windows APIs. We decided to go opensource on it as it could help others in the same situation to go without OpenSSL.

We're opened to do edits on anything if needed, Best regards.

google-cla[bot] commented 3 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

plusvic commented 3 months ago

Notice that the Authenticode parser is an external project (https://github.com/avast/authenticode-parser), and YARA simply has a copy of it. I prefer not deviating too much from their implementation, so that I can merge new updates with ease in the future. So, you should propose this change to the owners of the https://github.com/avast/authenticode-parser repository instead.